Handling of non-positive values causing log10 warnings on EK calibration #986
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle values <= 0 (0 and negative values) in calibration compute to eliminate log10 warnings. For the dataarrays causing these warnings, sets non-negative values to a slightly positive non-zero value.
Addresses #737
Note: when I ran the test suite locally there were a bunch of errors unrelated to the warnings addressed here. I'm going to assume there's some other mess in my test setup or some temporary glitch, and let the CI tests take a crack. All the log10 warnings in
test_range_integration.py
are gone.