Add NOAA s3 bucket and reversed time files to test_combine_echodata
#830
Conversation
…p using combine_lazily_v2
…a full EchoData combine
…llel write of coords
for more information, see https://pre-commit.ci
…ault compressor in zarr_combine.py
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
In discussing #798 we decided to do #833 (to remove the check for reversed and duplicated timestamps) in In the meantime, @leewujung will create smaller files from those EK80 narrowband that contain different lengths along the |
|
@b-reyes : Alright, I've reduced the EK80 test files and put them in the |
… remove storage parameter from fixture, and correct the README
Co-authored-by: Wu-Jung Lee <leewujung@gmail.com>
|
@leewujung I am done modifying the test data parameters so that they now use the data within |
|
Look good, thanks!! Feel free to merge this. |
Sounds good. I will merge this once PR #824 is merged. |
Codecov Report
@@ Coverage Diff @@
## dev #830 +/- ##
==========================================
+ Coverage 83.25% 89.38% +6.12%
==========================================
Files 52 10 -42
Lines 5010 989 -4021
==========================================
- Hits 4171 884 -3287
+ Misses 839 105 -734
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
In this PR I added EK60 and EK80 files from the NOAA s3 bucket to
test_combine_echodata. I additionally added EK60 reversed time files that are currently on our drive. I am failing the EK80 files that are narrowband and have differentrange_samplelengths amongst the data files. The reason for this is that they cause an error to occur in_clean_ping_time(please see issue #798).Note: This PR is a branch of
b-reyes:fix-data-loss(see PR #824). A version oftest_combine_echodataalso lives there, thus, this PR should only be merged once PR #824 has been merged. Also, please note that all of the changes not yet merged into dev fromb-reyes:fix-data-losswill show up in this PR (these should not be reviewed).