-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul access pattern [all tests ci] #762
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #762 +/- ##
==========================================
- Coverage 82.33% 82.18% -0.16%
==========================================
Files 46 48 +2
Lines 4240 4249 +9
==========================================
+ Hits 3491 3492 +1
- Misses 749 757 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lsetiawan : thanks for the PR! Sorry it took me forever to get to this.
The PR looks great, there's just this repeated block that handles whether beam
is connected to echodata["Sonar/Beam_group1"]
or echodata["Sonar/Beam_group2"]
that I feel the if/else + try/except logic should be a little different. See what you think, it is possible that I misunderstood something.
Co-authored-by: Don Setiawan <landungs@uw.edu>
Co-authored-by: Don Setiawan <landungs@uw.edu>
@leewujung This is now ready for your final review hopefully 😄 |
Awesome, thanks! I think once it's merged there would be some conflicts popping up for #774. Since you have both on your mind, perhaps it won't be so bad! |
try: | ||
ed['SomeRandomGroup'] = 'Testing value' | ||
except Exception as e: | ||
assert isinstance(e, GroupNotFoundError) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lsetiawan : I think this PR is ready to be merged! Just had a minor suggestion on a comment. It is nice to see how changing the getitem output to None makes the code so much cleaner to read.
Co-authored-by: Wu-Jung Lee <leewujung@gmail.com>
This PR overhauls the old attribute based access pattern in favor of path key access pattern for EchoData.
Resolves #708