Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing convention-required Platform variables to AZFP #654

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

imranmaj
Copy link
Contributor

@imranmaj imranmaj commented Apr 28, 2022

  • Adds missing convention-required Platform variables to AZFP
  • Adds tests for those variables

Part of #649 and #592

@imranmaj imranmaj requested review from leewujung and b-reyes April 28, 2022 00:56
@imranmaj imranmaj changed the title Add missing convention-required Platform variables Add missing convention-required Platform variables to AZFP Apr 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2022

Codecov Report

Merging #654 (d3b1a7a) into dev (fc253c1) will decrease coverage by 5.39%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #654      +/-   ##
==========================================
- Coverage   78.75%   73.35%   -5.40%     
==========================================
  Files          42       15      -27     
  Lines        3784     2327    -1457     
==========================================
- Hits         2980     1707    -1273     
+ Misses        804      620     -184     
Flag Coverage Δ
unittests 73.35% <100.00%> (-5.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
echopype/convert/set_groups_azfp.py 98.38% <100.00%> (ø)
echopype/convert/set_groups_base.py 88.17% <0.00%> (-2.16%) ⬇️
echopype/convert/utils/ek_raw_parsers.py 54.90% <0.00%> (-0.17%) ⬇️
echopype/calibrate/calibrate_base.py
echopype/qc/api.py
echopype/utils/coding.py
echopype/echodata/widgets/widgets.py
echopype/__init__.py
echopype/echodata/convention/__init__.py
echopype/calibrate/calibrate_ek.py
... and 20 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@leewujung
Copy link
Member

LGTM! Thanks!

@leewujung leewujung merged commit dda8a5e into OSOceanAcoustics:dev Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants