-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update setup-services.py to include images & volumes subtleties #651
Conversation
Make this optional? Often I tear-down to not have active containers, but I'd like to have the ability to restart from the images w/o downloading everything (deploy) again. |
Just to add more details on this PR:
|
Perfect
Perfect |
Co-authored-by: Don Setiawan <landungs@uw.edu>
I've looked at the changes in the PR and confirmed that your description of what has changed matches what we had discussed. I'm not going to run this locally to test it, though. I'm good with your own local tests and what happens once the PR is merged, next time the CI tests are run. I'll test it locally the next time I pull the merged changes and have to run the test suite. |
This PR makes
--tear-down
to also clean up images and volumes.