-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old API (those prior to v0.5.0) #601
Conversation
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## dev #601 +/- ##
===========================================
- Coverage 79.18% 59.88% -19.30%
===========================================
Files 41 40 -1
Lines 3623 3600 -23
===========================================
- Hits 2869 2156 -713
- Misses 754 1444 +690
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Feel free to either bring back the if section I mentioned above or leave your changes alone 😄
Thanks @lsetiawan ! I will leave that section in for future use. :) |
Thinking about it, I wonder if we can add like specific connected modules that should also be run for that module if it uses functions from those connected modules. Does that make sense? 😆 This way, we can have an "extensive" test without having to run the whole test! |
Definitely worth discussion as part of #552! This seems would fall in line with the integration test. |
@emiliom : thanks for finding the Also, I think it's fine to remove the reference to old API altogether. Our docs are versioned so folks can hopefully find what they need if they really wanted to use the old versions. I'll make these changes in the docs also. |
I think this is ready to merge. Thanks for pursuing this! Good riddance 😆 |
This PR removes the old API
Convert
andProcess
prior to v0.5.0.The changes include:
process
,convert/convert.py
,convert/convert_combine.py
This addresses #506.