Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test run command to get more accurate coverage. #411

Merged
merged 4 commits into from
Aug 11, 2021

Conversation

lsetiawan
Copy link
Member

This PR fixes caching and also updates the run test command so it can give an accurate assessment of test coverage, which should be around 76%.

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2021

Codecov Report

Merging #411 (17a5b17) into dev (5c100f4) will increase coverage by 73.24%.
The diff coverage is 95.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##             dev     #411       +/-   ##
==========================================
+ Coverage   2.21%   75.46%   +73.24%     
==========================================
  Files         35       35               
  Lines       3019     3032       +13     
==========================================
+ Hits          67     2288     +2221     
+ Misses      2952      744     -2208     
Flag Coverage Δ
unittests 75.46% <95.58%> (+73.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
echopype/preprocess/api.py 87.17% <ø> (+87.17%) ⬆️
echopype/utils/io.py 84.21% <95.16%> (+58.28%) ⬆️
echopype/convert/api.py 86.40% <100.00%> (+86.40%) ⬆️
echopype/convert/utils/ek_raw_io.py 42.61% <100.00%> (+42.61%) ⬆️
echopype/echodata/echodata.py 75.20% <100.00%> (+40.24%) ⬆️
echopype/convert/utils/ek_date_conversion.py 33.33% <0.00%> (+33.33%) ⬆️
echopype/convert/parse_ek80.py 50.00% <0.00%> (+50.00%) ⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c41a5cf...17a5b17. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants