Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set decode timedelta to False since it will default to this in later xarray version [all tests ci] #1462

Merged

Conversation

ctuguinay
Copy link
Collaborator

@ctuguinay ctuguinay commented Feb 17, 2025

Resolves /~https://github.com/OSOceanAcoustics/echopype/actions/runs/13098048680/job/36542811253?pr=1429#step:15:944 found in #1439:

Warning: In a future version of xarray decode_timedelta will default to False rather than None. To silence this warning, set decode_timedelta to True, False, or a 'CFTimedeltaCoder' instance.

@ctuguinay ctuguinay marked this pull request as draft February 17, 2025 22:52
@ctuguinay ctuguinay changed the title Set decode timedelta to False since it will default to this in later xarray version Set decode timedelta to False since it will default to this in later xarray version [all tests ci] Feb 17, 2025
@ctuguinay ctuguinay closed this Feb 17, 2025
@ctuguinay ctuguinay reopened this Feb 17, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.22%. Comparing base (9f56124) to head (c3b308e).
Report is 180 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1462      +/-   ##
==========================================
+ Coverage   83.52%   85.22%   +1.69%     
==========================================
  Files          64       72       +8     
  Lines        5686     6590     +904     
==========================================
+ Hits         4749     5616     +867     
- Misses        937      974      +37     
Flag Coverage Δ
unittests 85.22% <ø> (+1.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctuguinay ctuguinay marked this pull request as ready for review February 17, 2025 23:12
@ctuguinay ctuguinay self-assigned this Feb 17, 2025
@ctuguinay ctuguinay added the bug Something isn't working label Feb 17, 2025
@ctuguinay ctuguinay added this to the v0.9.2 milestone Feb 17, 2025
@ctuguinay ctuguinay requested a review from leewujung February 17, 2025 23:13
@ctuguinay
Copy link
Collaborator Author

@leewujung Really short change, ready for review

@leewujung
Copy link
Member

I was curious what would happen if we set decode_timedelta = True. Turned out that the "MatlabTimeStamp" variable gets messed up:
Screenshot 2025-02-17 at 9 58 20 PM

Copy link
Member

@leewujung leewujung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Merging now.

@leewujung leewujung merged commit 938e535 into OSOceanAcoustics:main Feb 18, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants