-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for AZFP 130kHz #1412
Add support for AZFP 130kHz #1412
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1412 +/- ##
==========================================
- Coverage 83.52% 80.31% -3.21%
==========================================
Files 64 18 -46
Lines 5686 3089 -2597
==========================================
- Hits 4749 2481 -2268
+ Misses 937 608 -329
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Oh wait, perhaps I don't need to check all 3 locations for that frequency haha. Let me change that in the morning. |
@leewujung This should be ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ctuguinay! This looks great.
The only comment I have is to add also a dict item for 120000.0 since ASL said that the same 150us and 250us mapping could be used for 120, 125, and 130 kHz transducers. Feel free to merge once that is added.
@leewujung Oh huh apparently still needs you approval to merge something so small 😆 |
Oh wow, ok. Sorry I had missed this - will merge now! |
As indicated by Steve Pearce from ASL, I used the same transmit frequency, pulse length, Sv compensation mapping that 125kHz has for 130kHz.
This addresses #1304, #1305.