Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v.out.vtk: Output double data type instead of float #2562

Merged
merged 3 commits into from
Oct 5, 2022
Merged

v.out.vtk: Output double data type instead of float #2562

merged 3 commits into from
Oct 5, 2022

Conversation

wenzeslaus
Copy link
Member

@wenzeslaus wenzeslaus changed the title v vtk double v.out.vtk: Output double data type instead of float Aug 28, 2022
@wenzeslaus wenzeslaus added enhancement New feature or request C Related code is in C labels Aug 28, 2022
@wenzeslaus wenzeslaus mentioned this pull request Aug 28, 2022
Closed
@wenzeslaus wenzeslaus added this to the 8.3.0 milestone Aug 28, 2022
@wenzeslaus
Copy link
Member Author

This is a replacement for #2360 with fixed indentation (the branch for #2360 was not writable).

According to Kitware VTKFileFormats, the POINTS %i double line is correct, so we can merge this.

dataType is one of the types bit, unsigned_char, char, unsigned_short, short, unsigned_int, int, unsigned_long, long, float, or double.
POINTS n dataType

@wenzeslaus wenzeslaus merged commit f9a30a3 into OSGeo:main Oct 5, 2022
@wenzeslaus wenzeslaus deleted the v-vtk-double branch October 5, 2022 03:21
@wenzeslaus
Copy link
Member Author

Merged. Thank you @BadAssassin!

ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
@wenzeslaus @BadAssassin @ninsbl
v.out.vtk: Output double data type instead of float (OSGeo#2562)
dbb88ba 
Geometric information in the VTK Polydata dataset output of the v.out.vtk function are now saved as datatype double instead of float which is more suitable considering the amount of digits in geographic coordinates.

The 'POINTS n dataType' line now uses double dataType (float, double, int and more is allowed).

Fixes OSGeo#864.

Actual code change written by Brad ReDacted.

Co-authored-by: Brad ReDacted <brad.redacted@outlook.com>
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
@wenzeslaus @BadAssassin @ninsbl
v.out.vtk: Output double data type instead of float (OSGeo#2562)
907faf9 
Geometric information in the VTK Polydata dataset output of the v.out.vtk function are now saved as datatype double instead of float which is more suitable considering the amount of digits in geographic coordinates.

The 'POINTS n dataType' line now uses double dataType (float, double, int and more is allowed).

Fixes OSGeo#864.

Actual code change written by Brad ReDacted.

Co-authored-by: Brad ReDacted <brad.redacted@outlook.com>
marisn pushed a commit to marisn/grass that referenced this pull request Jun 2, 2023
@wenzeslaus @BadAssassin @marisn
v.out.vtk: Output double data type instead of float (OSGeo#2562)
4833a0e 
Geometric information in the VTK Polydata dataset output of the v.out.vtk function are now saved as datatype double instead of float which is more suitable considering the amount of digits in geographic coordinates.

The 'POINTS n dataType' line now uses double dataType (float, double, int and more is allowed).

Fixes OSGeo#864.

Actual code change written by Brad ReDacted.

Co-authored-by: Brad ReDacted <brad.redacted@outlook.com>
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
@wenzeslaus @BadAssassin @neteler
v.out.vtk: Output double data type instead of float (OSGeo#2562)
380be41 
Geometric information in the VTK Polydata dataset output of the v.out.vtk function are now saved as datatype double instead of float which is more suitable considering the amount of digits in geographic coordinates.

The 'POINTS n dataType' line now uses double dataType (float, double, int and more is allowed).

Fixes OSGeo#864.

Actual code change written by Brad ReDacted.

Co-authored-by: Brad ReDacted <brad.redacted@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C Related code is in C enhancement New feature or request
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wenzeslaus @BadAssassin