Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r.resamp.interp: implement parallelization with OpenMP #1771

Merged
merged 9 commits into from
Dec 9, 2022
Merged

r.resamp.interp: implement parallelization with OpenMP #1771

merged 9 commits into from
Dec 9, 2022

Conversation

aaronsms
Copy link
Contributor

@aaronsms aaronsms commented Aug 2, 2021 •
edited by petrasovaa
Loading

  • Update Makefile
  • Add memory and nprocs parameter
  • Implement parallelization

Checklists before merging:

  • code review
  • CI passes
  • performance section in documentation
  • confirm values in test are from the old version (run new tests with old code)
  • run tests without OpenMP
  • visual check of results with custom data ("looks good" with non NC SPM dataset)
  • check that it works with really large data (16B cells)
  • run multi-core benchmark (no degraded performance with many threads)
  • run one core benchmark on many resolutions or many cell
  • rebase to main
  • run with valgrind

marisn
marisn approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@marisn marisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I run module on a small dataset and the results seemed to come out just fine.

raster/r.resamp.interp/main.c Show resolved Hide resolved
@wenzeslaus wenzeslaus added enhancement New feature or request gsoc Reserved for Google Summer of Code student(s) labels Aug 5, 2021
@HuidaeCho HuidaeCho added the raster Related to raster data processing label Aug 6, 2021
@HuidaeCho
Copy link
Member

Please add a test script.

@aaronsms aaronsms force-pushed the parallel-r.resamp.interp branch from c65ff3e to cb6bc15 Compare August 13, 2021 12:48
@aaronsms aaronsms force-pushed the parallel-r.resamp.interp branch from cb6bc15 to 851f606 Compare August 20, 2021 12:54
@wenzeslaus wenzeslaus added this to the 8.2.0 milestone Aug 24, 2021
@aaronsms aaronsms force-pushed the parallel-r.resamp.interp branch from 851f606 to f55fbcb Compare December 5, 2021 11:16
@wenzeslaus wenzeslaus modified the milestones: 8.2.0, 8.4.0 Mar 16, 2022
@petrasovaa
Copy link
Contributor

This is for 7 billion cells.
results

It does not scale great, but it's still a nice improvement, it can decrease time roughly by half.

I believe this is ready to merge.

@petrasovaa petrasovaa merged commit 352a038 into OSGeo:main Dec 9, 2022
@petrasovaa petrasovaa mentioned this pull request Dec 9, 2022
Merged
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
@aaronsms @ninsbl
r.resamp.interp: implement parallelization with OpenMP (OSGeo#1771)
be653b5
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
@aaronsms @neteler
r.resamp.interp: implement parallelization with OpenMP (OSGeo#1771)
c0b8ab8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marisn marisn marisn approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request gsoc Reserved for Google Summer of Code student(s) raster Related to raster data processing
Projects
None yet
Milestone
8.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@aaronsms @HuidaeCho @petrasovaa @marisn @wenzeslaus