Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport NKG unique names #4111

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Conversation

kbevers
Copy link
Member

@kbevers kbevers commented Apr 4, 2024

Backport of #4098 and 92de8aa. I guess this could be omitted since the name consistency checks have not been backported (yet?) but it may as well be kept up to date.

@rouault let me know if you disagree with this backport.

@rouault rouault added this to the 9.4.1 milestone Apr 4, 2024
@rouault
Copy link
Member

rouault commented Apr 4, 2024

I'm fine with this backport

@kbevers
Copy link
Member Author

kbevers commented Apr 4, 2024

The windows builds aren't though. Safe to merge anyways? Doesn't seem to be related to this change

@jjimenezshaw
Copy link
Contributor

The windows builds aren't though. Safe to merge anyways? Doesn't seem to be related to this change

I mentioned it already a few days ago: https://lists.osgeo.org/pipermail/proj/2024-April/011342.html
It is not related with your changes. But we do not have any windows MSVC CI running in case there is a problem there.

@rouault
Copy link
Member

rouault commented Apr 4, 2024

But we do not have any windows MSVC CI running in case there is a problem there.

hopefully the vcpkg folks will figure out soon a clean solution, although the situation in their bug tracker is confusing, with people keeping opening issues about that (microsoft/vcpkg#37962, microsoft/vcpkg#37970), and being pointed to the workaround of microsoft/vcpkg#37962 (comment)
anyway nothing MSVC specific in this PR, merging

@rouault rouault merged commit 589e01e into OSGeo:9.4 Apr 4, 2024
19 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants