Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake/Ccache.cmake: raise cmake_minimum_required() as newer CMake versions warn that support for CMake < 3.5 is going to be dropped at some later point #3979

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

rouault
Copy link
Member

@rouault rouault commented Dec 8, 2023

No description provided.

…sions warn that support for CMake < 3.5 is going to be dropped at some later point
@kbevers
Copy link
Member

kbevers commented Dec 8, 2023

Will this make CMake 3.9 a requirement? If so, RFC3 states that

Changes for software package dependencies can be introduced with minor version releases of PROJ. Changing the version requirements for a dependency needs to be approved by the PSC.

@rouault
Copy link
Member Author

rouault commented Dec 8, 2023

Will this make CMake 3.9 a requirement?

it is already :-) :-) Cf root CMakeLists.txt: /~https://github.com/OSGeo/PROJ/blob/master/CMakeLists.txt#L12

@kbevers
Copy link
Member

kbevers commented Dec 8, 2023

it is already :-)

Well, great :-) I guess RFC3 is not up to date then. It says the minimum CMake requirement is 3.5

@rouault
Copy link
Member Author

rouault commented Dec 8, 2023

I guess RFC3 is not up to date then

was overriden by a PSC vote in Feb 2020: https://lists.osgeo.org/pipermail/proj/2020-February/009324.html

@kbevers
Copy link
Member

kbevers commented Dec 8, 2023

Yes, that was clear from the previous message. My point was that it would be nice to have the current requirements reflected in the RFC - I don't regard them as static documents

@rouault rouault merged commit 657c69c into OSGeo:master Dec 8, 2023
22 checks passed
@mwtoews
Copy link
Member

mwtoews commented Dec 9, 2023

It could also be removed (e.g. this was done for geos libgeos/geos@3d4870f). This statement is only needed per-project, whereas I might have thought this was a per-module spec. But this merge fix is also fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants