-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Database: update to EPSG 10.088 #3731
Conversation
The import script has been modified to avoid import errors on the following Danish CRS: - Skipping EPSG:10258 GS reconstruction east-orientated as we do not handle yet projection method EPSG:1102 / Lambert Conic Conformal (1SP variant B) - Skipping EPSG:10262 GSB reconstruction east-orientated as we do not handle yet projection method EPSG:1102 / Lambert Conic Conformal (1SP variant B) - Skipping EPSG:10266 KK reconstruction east-orientated as we do not handle yet projection method EPSG:1102 / Lambert Conic Conformal (1SP variant B)
The expected PROJ expressions are:
If the problem relates to whether PROJ implements Variant A (EPSG:9801) or Variant B (EPSG:1102), I did actually check whether PROJ implements one or the other prior to submitting the material to EPSG. I did so by checking the examples from the IOGP Guidance Note 7.2, and as shown below, PROJ implements Variant B (EPSG:1102). LCC 1SP, Variant B: Example from "IOGP Publication 373-7-2 – Geomatics Guidance Note number 7, part 2 – May 2022, section 3.4.1.3, p. 23" Parameters
Test point
PROJ implementation:
Conformance! - i.e. PROJ implements variant B LCC 1SP, Variant A: Example from "IOGP Publication 373-7-2 – Geomatics Guidance Note number 7, part 2 – May 2022, section 3.4.1.2, p. 22" Parameters
Test point
PROJ implementation:
Discrepancy - i.e. PROJ does not implement "Variant A"
Your guess is correct :-) The process with registering old Danish systems with EPSG has been extremely long an winded, but the grids have already been available from the SDFI ftp-server for some time now. |
Ouch, I almost had a heart attack reading this given this is a widely used method, but you just got the numerical application wrong, with the sign of the input longitude :-) Here's the correct input that shows we are conformant:
The good news is that the mapping of LCC_1SP variant B to +proj=lcc is trivial. I'll look at adding the mapping part |
Thanks for noticing - never a good idea trying to reconstruct year-old computations at 6 in the morning after a sleepless night :-) ... the sheer amount of offset should obviously have told me, especially since it is just a few days ago, I diagnosed a similar case in connection with some old Greenlandic Systems. In other words, the PROJ implementation is conforming for both Variant A and B, the difference is exclusively in the selection of parameters. Originally, I probably tried variant B only, concluded it was PROJ compatible, then proceeded using it for the relevant parts of the "reconstruction of old Danish systems" project. |
Support for LCC 1SP Variant B added in extra commit:
|
…ethod, and import related EPSG records
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I'll add the grids to PROJ-data within the next couple of days.
@rouault the first commit can be backported, right? |
yes, I see I forgot to add the backport tag. Will do manually. actually I intended to backport both commits, unless you want otherwise. |
I think it's fine. I figured you didn't add the backport tag because the second commit sort of introduces new functionality. I agree that backporting both is suitable. |
The import script has been modified to avoid import errors on the following Danish CRS:
CC @busstoptaktik Looking at EPSG revision history, it appears you're the one having submitted the above CRS to IOGP. Currently we don't import them into proj.d as the projection method EPSG:1102 / Lambert Conic Conformal (1SP variant B) is not mapped to a PROJ map projection. Do you have a plan doing that ?
I also see new grids being added. I guess you'll submit them to PROJ-data ?