cass: fix forward computation of easting (fixes #3432), … #3433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you mind splitting this in to different commits? One with the fix for Cassini-Soldner and one with the generic inverse improvement. |
The error on the sign after "nu * A * (1. - A2 * T * (C1 ...") dates back to PROJ origins. All other independent implementations (Apache SIS cf /~https://github.com/apache/sis/blob/a04bd4b29816c91fc4dfc66135b8de5e962933a0/core/sis-referencing/src/main/java/org/apache/sis/referencing/operation/projection/CassiniSoldner.java, CSMAP cf /~https://github.com/normanb/CS-Map/blob/1d8f2db7f13194a99dc218d4cd91754c64a2a774/Source/CS_csini.c) use the same formulas as EPSG guidance note which is consistent with Snyder's Map projections - A working manual). So align on them, so that everyone is consistent (and hopefully right).
… tests succeed I've modified the inverse method to use the generic inversion method to improve its accuracy, which make it possible to enable the 5108.gie tests that were previously failing on the 1000 iterations roundtripping.
done |
Thanks. |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 7, 2022
cass: fix forward computation of easting (fixes #3432), …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and use iterative generic inversion to make GIGS 5108 roundtripping tests succeed
The error on the sign after "nu * A * (1. - A2 * T * (C1 ...") dates back to PROJ origins. All other independent implementations (Apache SIS cf
/~https://github.com/apache/sis/blob/a04bd4b29816c91fc4dfc66135b8de5e962933a0/core/sis-referencing/src/main/java/org/apache/sis/referencing/operation/projection/CassiniSoldner.java, CSMAP cf
/~https://github.com/normanb/CS-Map/blob/1d8f2db7f13194a99dc218d4cd91754c64a2a774/Source/CS_csini.c) use the same formulas as EPSG guidance note which is consistent with Snyder's Map projections - A working manual). So align on them, so that everyone is consistent (and hopefully right).
While doing it, I've modified the inverse method to use the generic inversion method to improve its accuracy, which make it possible to enable the 5108.gie tests that were previously failing on the 1000 iterations roundtripping.