-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for more generic Space Oblique Mercator (SOM) projection #3338
Conversation
To avoid the code duplication, if the only difference is hard-coded parameters vs user-provided one, a better way would be to have a common setup() method to misrom and genericsom, and have the entry points of the 2 functions call it. Like "utm" and "tmerc" in src/projections/tmerc.cpp (there are other similar instances in sconics.cpp, putp6.cpp, etc.) |
I think I understand. From my point of view, it looks like misrsom is a more specialized version of genericsom. Would it work for you to keep the currently duplicated code in genericsom (with modification if necessary to support re-use) and modify misrsom to use the functions from genericsom rather than be duplicated? |
that's exactly what I meant :-) Basically you'd remove misrom.cpp entirely, and just move its entry point |
Thanks! I'll make the change and push once more. |
docs/source/*.rst
for new API