implement alterCSLinearUnit for CompoundCRS #3325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
reviewed
Sep 14, 2022
| auto crs = | ||
| createCompoundCRS()->alterCSLinearUnit(UnitOfMeasure("my unit", 2)); | ||
| EXPECT_TRUE(createCompoundCRS()->isEquivalentTo(crs.get())); | ||
| auto compoundCRS = dynamic_cast<CompoundCRS *>(crs.get()); |
There was a problem hiding this comment.
for the sake of completness, and test line 393 of crs.cpp, we'd need a test on a type of CRS that has no implementation of alterCSLinearUnit(). For example a temporal or parametric CRS
jjimenezshaw
force-pushed
the
alterCSLinearUnit-compound
branch
from
dfa1ebe to
a48a69e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For completeness, this PR implements
alterCSLinearUnitforCompoundCRS, applyingalterCSLinearUniton every component.