-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some improvements to the docs for tmerc and omerc #1281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is very good. I would suggest only keeping the first paragraph ("The Oblique Mercator projection is a cylindrical map projection that closes the
gap between the Mercator and the Transverse Mercator projections") above the classification table and moving the rest of the intro-text below the table. This conforms to the style that is used in most other properly documented projection as well as giving a quick overview of the table without scrolling down the page.
There's some good figures in #523. I don't know the source of the figures but if we are allowed to include them (or reproductions of them) I think they would help illustrate some of the points made about he different types of rotations that can be applied. It's probably a job for another day but at least it is worth considering this as a future improvement.
The updates to |
Not as related as I expected when starting the work: While omerc clearly being mostly in need of a touch up, I thought of it as an occasion for a general overhaul of omerc, tmerc, and merc, giving an overall better feeling that they are in close family, although looking much different. I think I got part of that message through in the intro to omerc, but I ran short of time before getting through everything. So, yes, it was the idea to make changes logically tied across all 3 projections, but that is probably not terribly evident from this PR. |
docs/source/references.bib
Outdated
author = {Mikael Rittri}, | ||
title = {New omerc approximations of Denmark System 34}, | ||
year = {2012}, | ||
url = {http://lists.maptools.org/pipermail/proj/2012-June/006323.html} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you change this to https://lists.osgeo.org/pipermail/proj/2012-June/005926.html , since maptools.org is probably going to be retired at some point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing this - I had planned to change it, but forgot about it
It won't render correctly otherwise.
Over at #523, @ralphtee gave some very nice explanations for omerc. I have added some of this material + a some descriptional text to the docs for omerc.
Additionally clarified a few things about algorithms in the docs for tmerc.