Migrate pipelines to 1ES #2841
Migrate pipelines to 1ES #2841
Conversation
habbes
requested review from
xuzhg,
marabooy,
paulodero,
KenitoInc,
ElizabethOkerio and
gathogojr
| platform: $(BuildPlatform) | ||
| configuration: $(BuildConfiguration) | ||
| - task: DotNetCoreCLI@2 | ||
| displayName: 'build Microsoft.AspNetCore.OData.csproj ' |
There was a problem hiding this comment.
nit:
| displayName: 'build Microsoft.AspNetCore.OData.csproj ' | |
| displayName: 'Build Microsoft.AspNetCore.OData.csproj ' |
Most other displayName start with upper case
| projects: $(Build.SourcesDirectory)\src\Microsoft.AspNetCore.OData\Microsoft.AspNetCore.OData.csproj | ||
| arguments: --configuration $(BuildConfiguration) --no-incremental | ||
| - task: DotNetCoreCLI@2 | ||
| displayName: build .NET Core Unit test project |
There was a problem hiding this comment.
See my comment here /~https://github.com/OData/WebApi/pull/2841/files#r1619893321
| projects: $(Build.SourcesDirectory)\test\UnitTest\Microsoft.AspNetCore.OData.Test\Microsoft.AspNetCore.OData.Test.csproj | ||
| arguments: --configuration $(BuildConfiguration) --no-incremental | ||
| - task: DotNetCoreCLI@2 | ||
| displayName: build .NET Core E2E test project |
There was a problem hiding this comment.
See my comment here /~https://github.com/OData/WebApi/pull/2841/files#r1619893321
| projects: $(Build.SourcesDirectory)\test\E2ETest\Microsoft.Test.E2E.AspNet.OData\Build.AspNetCore\Microsoft.Test.E2E.AspNetCore.OData.csproj | ||
| arguments: --configuration $(BuildConfiguration) --no-incremental | ||
| - task: DotNetCoreCLI@2 | ||
| displayName: build .NET Core 3x E2E test project |
There was a problem hiding this comment.
See my comment here /~https://github.com/OData/WebApi/pull/2841/files#r1619893321
| inputs: | ||
| command: test | ||
| projects: $(Build.SourcesDirectory)\test\E2ETest\Microsoft.Test.E2E.AspNet.OData\Build.AspNetCore3x\Microsoft.Test.E2E.AspNetCore3x.OData.csproj | ||
| arguments: --configuration $(BuildConfiguration) --no-build --filter FullyQualifiedName!=Microsoft.Test.E2E.AspNet.OData.QueryComposition.SelectExpandEFTests.QueryForLongSelectList -v diag |
There was a problem hiding this comment.
Would you know why we filter out this particular test(s)?
| platform: $(BuildPlatform) | ||
| configuration: $(BuildConfiguration) | ||
| - task: DotNetCoreCLI@2 | ||
| displayName: 'build Microsoft.AspNetCore.OData.csproj ' |
There was a problem hiding this comment.
See my comment here /~https://github.com/OData/WebApi/pull/2841/files#r1619893321
| projects: $(Build.SourcesDirectory)\src\Microsoft.AspNetCore.OData\Microsoft.AspNetCore.OData.csproj | ||
| arguments: --configuration $(BuildConfiguration) --no-incremental | ||
| - task: DotNetCoreCLI@2 | ||
| displayName: build .NET Core Unit test project |
There was a problem hiding this comment.
See my comment here /~https://github.com/OData/WebApi/pull/2841/files#r1619893321
| projects: $(Build.SourcesDirectory)\test\UnitTest\Microsoft.AspNetCore.OData.Test\Microsoft.AspNetCore.OData.Test.csproj | ||
| arguments: --configuration $(BuildConfiguration) --no-incremental | ||
| - task: DotNetCoreCLI@2 | ||
| displayName: build .NET Core E2E test project |
There was a problem hiding this comment.
See my comment here /~https://github.com/OData/WebApi/pull/2841/files#r1619893321
| projects: $(Build.SourcesDirectory)\test\E2ETest\Microsoft.Test.E2E.AspNet.OData\Build.AspNetCore\Microsoft.Test.E2E.AspNetCore.OData.csproj | ||
| arguments: --configuration $(BuildConfiguration) --no-incremental | ||
| - task: DotNetCoreCLI@2 | ||
| displayName: build .NET Core 3x E2E test project |
There was a problem hiding this comment.
See my comment here /~https://github.com/OData/WebApi/pull/2841/files#r1619893321
| inputs: | ||
| command: test | ||
| projects: $(Build.SourcesDirectory)\test\E2ETest\Microsoft.Test.E2E.AspNet.OData\Build.AspNetCore3x\Microsoft.Test.E2E.AspNetCore3x.OData.csproj | ||
| arguments: --configuration $(BuildConfiguration) --no-build --filter FullyQualifiedName!=Microsoft.Test.E2E.AspNet.OData.QueryComposition.SelectExpandEFTests.QueryForLongSelectList -v diag |
There was a problem hiding this comment.
Out of scope, but would you know why we filter out this particular test(s)?
| displayName: Classic E2E Tests (Microsoft.Test.E2E.AspNet.OData.dll) | ||
| inputs: | ||
| testAssemblyVer2: '**\bin\**\E2ETest\**\Microsoft.Test.E2E.AspNet.OData.dll' | ||
| testFiltercriteria: (DisplayName!=Microsoft.Test.E2E.AspNet.OData.ODataPathHandler.UnicodeRouteTests_Todoü.CRUDEntitySetShouldWork) |
There was a problem hiding this comment.
Out of scope, but would you know why we filter out this particular test(s)? We don't skip it in the nightly build
There was a problem hiding this comment.
I'm not sure. My initial guess woulld be to reduce runtime.
This PR migrates the build pipelines to 1ES.