Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#305 SwiftCBOR package repository url updated #306

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

antkont
Copy link
Contributor

@antkont antkont commented Jan 8, 2025

Outdated SwiftCBOR package url updated
#305

@CLAassistant
Copy link

CLAassistant commented Jan 8, 2025

CLA assistant check
All committers have signed the CLA.

@dinesharjani
Copy link
Contributor

Hello @antkont - can you provide some explanation? The CBOR library package we're using seems to be kept up to date, at least the GitHub repo.

@antkont
Copy link
Contributor Author

antkont commented Jan 8, 2025

So the SPM sees the repos as 2 different repos although they redirect exactly to the same repo. I do have the valpackett added in project separately.

Here is the error:

'ios-nrf-connect-device-manager' dependency on '/~https://github.com/unrelentingtech/SwiftCBOR.git' conflicts with dependency on '/~https://github.com/valpackett/SwiftCBOR.git' which has the same identity 'swiftcbor'. this will be escalated to an error in future versions of SwiftPM.

If you follow the /~https://github.com/unrelentingtech/SwiftCBOR.git link it redirects to /~https://github.com/valpackett/SwiftCBOR.git, pay attention to the address after clicking the first link.

So only the unnecessary redirect is eliminated here, underlying codebase is the exact same.

@dinesharjani dinesharjani merged commit f2d812d into NordicSemiconductor:main Jan 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants