Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buidler-etherscan plugin: increase verification delay 1000 -> 3000. #527

Merged
merged 1 commit into from
Apr 28, 2020
Merged

buidler-etherscan plugin: increase verification delay 1000 -> 3000. #527

merged 1 commit into from
Apr 28, 2020

Conversation

tmilar
Copy link
Contributor

@tmilar tmilar commented Apr 22, 2020 •
edited
Loading 

* Otherwise the delay between requests is too short, and
Etherscan API might return an error:
`Max rate limit reached, please use API Key for higher rate limit`.

@tmilar
buidler-etherscan plugin: increase verification response delay 1000 -…
1453151 
…> 3000.

    * Otherwise the delay between requetss is too short, and
  Etherscan API might return an error:
  `Max rate limit reached, please use API Key for higher rate limit`.
@alcuadrado alcuadrado merged commit e6c1aaf into development Apr 28, 2020
@alcuadrado alcuadrado deleted the fix-etherscan-api-limit-bug branch April 28, 2020 14:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
zoeyTM added a commit that referenced this pull request Dec 19, 2024
@zoeyTM
handle error thrown by status task (#541)
6088ac5 
Use a whitelist to determine whether a code `IgnitionError` should be rethrown as a Hardhat plugin error. This list can be added to as more Ignition errors are identified as being better displayed as HH errors.

We intend to extend the HH error code mechanism to give Ignition even more control over the display of errors in HH.

This change only adds this rethrow for status and the unrecognised deployment entry currently.

Fixes #527.
zoeyTM pushed a commit that referenced this pull request Dec 19, 2024
@kanej
remove support for module file names in tasks
2ea32d5 
We are removing support for invoking a module just by giving its file
name. Instead the tasks will work in terms of a full or relative path to
the module file.

Users prefer this for autocomplete reasons anyway, but it removes
confusion as to whether it is the `ModuleId` or filename that is in use
here.

Resolves #527.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmilar @alcuadrado