Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Refactor to expose endpoints #132

Merged
merged 5 commits into from
Oct 24, 2023
Merged

Conversation

AzulGarza
Copy link
Member

This PR refactors the TimeGPT class to have more direct access to the client's endpoint. Before this PR, the endpoints were highly nested across multiple endpoints, which created a nested architecture of the model's parameters (such as freq and h), making adding new endpoints and features difficult. This propose encapsulates reusable parameters in a new class _TimeGPTModel whose methods are only related to data frame inputs and additional parameters only related to the specific method or endpoint.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@AzulGarza AzulGarza merged commit 7c75374 into main Oct 24, 2023
@AzulGarza AzulGarza deleted the feat/refactor-common-params branch October 24, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant