Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mdadm: fix build with musl 1.2.5 #313936

Merged
merged 1 commit into from
May 29, 2024
Merged

mdadm: fix build with musl 1.2.5 #313936

merged 1 commit into from
May 29, 2024

Conversation

yu-re-ka
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@alyssais
Copy link
Member

I think we'll need md-raid-utilities/mdadm#14 or we'll get segfaults at runtime:

Monitor.c: In function ‘Monitor’:
Monitor.c:257:34: warning: implicit declaration of function ‘basename’ [-Wimplicit-function-declaration]
  257 |                                  basename(mdlist->devname));
      |                                  ^~~~~~~~

@yu-re-ka
Copy link
Contributor Author

I think we'll need md-raid-utilities/mdadm#14 or we'll get segfaults at runtime:

Applied

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label May 29, 2024
@yu-re-ka yu-re-ka merged commit b860928 into NixOS:master May 29, 2024
25 of 26 checks passed
@yu-re-ka yu-re-ka deleted the musl-mddam branch May 29, 2024 14:52
Copy link
Contributor

Successfully created backport PR for release-24.05:

florian-sanders-cc pushed a commit to florian-sanders-cc/nixpkgs that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants