Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libfaketime: backport LFS64 fix for musl 1.2.4 #313663

Merged
merged 1 commit into from
May 22, 2024

Conversation

alyssais
Copy link
Member

Description of changes

See #229439.

This is a very disappointing fix, as all it's doing is switching to another deprecated API, and kicking the can down the road, but if that's what upstream wants to do…

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This is a very disappointing fix, as all it's doing is switching to
another deprecated API, and kicking the can down the road, but if
that's what upstream wants to do…
@alyssais alyssais changed the base branch from master to staging May 22, 2024 12:11
@alyssais alyssais mentioned this pull request May 22, 2024
47 tasks
@yu-re-ka yu-re-ka merged commit 82ea1a7 into NixOS:staging May 22, 2024
7 of 9 checks passed
@alyssais alyssais deleted the libfaketime-lfs64 branch May 22, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants