-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
noto-fonts-emoji: Package both color and monochrome variants #254149
Conversation
@mkg20001 since you already saw the sourcery involved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! I added some feedback.
9095109
to
dc83279
Compare
I moved the file hashes to a second file (now in SRI format), and added a script to automate the update process, which:
|
1a3a05b
to
9b115ff
Compare
cbef467
to
752ea05
Compare
Changed the version away from |
It's kind of annoying we cannot set Google's own documentation has an “API Explorer” which does exactly that: some API key is passed to browser-side JS code, though that specific key is bound to the right |
We do have a Chromium key. It looks like @aszlig got permission for it many years ago. As mentioned in that commit, the public Google API TOS does forbid distributing API keys publicly (https://developers.google.com/terms: "Developer credentials may not be embedded in open source projects."), so a Fonts API key would similarly require special permission from Google. I'm not sure who you would reach out to now. |
Good luck... we're currently running into quota limits for these mentioned API keys (they're also used in Firefox btw.) and so far we were unable to reach anyone from Google who's in charge of these after multiple attempts. If you do for some reason find the right contact at Google, please let us know (cc: @mweinelt). The person mentioned in that referenced commit no longer works there. |
Thanks @aszlig and @Mathnerd314, for all the information. I'll see what I can do. :3 |
The test failure seems unrelated: I did not touch
|
Fixed in #254387. Please rebase. |
Clarify that the monochrome font is not included, per NixOS#221181. The new name is also coherent with the name of the font, according to `fontconfig`: Noto Color Emoji.
This hedges against a buggy version of the script generating data that is then blindly reused even after the bug is fixed.
Done |
Description of changes
Closes #221181.
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)