Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support selecting optional configs with selectConfig #82

Merged
merged 4 commits into from
Dec 27, 2021

Conversation

Nikaple
Copy link
Owner

@Nikaple Nikaple commented Dec 27, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Related issue linked using fixes #number
  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Selecting optional config marked as @Optional() will throw error when config does not exist.

Issue Number: N/A

What is the new behavior?

Can provide an optional argument { allowOptional: true } to select optional config.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Nikaple Nikaple merged commit 5852b52 into main Dec 27, 2021
@Nikaple Nikaple deleted the feat/select-config-optional branch December 27, 2021 14:21
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant