Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(model): wrong value type #402

Merged
merged 1 commit into from
Feb 28, 2023
Merged

fix(model): wrong value type #402

merged 1 commit into from
Feb 28, 2023

Conversation

r3st
Copy link
Contributor

@r3st r3st commented Feb 28, 2023

Fixed wrong type in models.go as described in #387

@Nerzal
Copy link
Owner

Nerzal commented Feb 28, 2023

Hi do you know if this was a change in between different keycloak versions, or was the model wrong all the time? :D

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #402 (56e7500) into main (9cd3f14) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #402   +/-   ##
=======================================
  Coverage   77.16%   77.16%           
=======================================
  Files           4        4           
  Lines        2172     2172           
=======================================
  Hits         1676     1676           
  Misses        337      337           
  Partials      159      159           
Impacted Files Coverage Δ
models.go 92.71% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@r3st
Copy link
Contributor Author

r3st commented Feb 28, 2023

Hi do you know if this was a change in between different keycloak versions, or was the model wrong all the time?

I will check this, but when it happens before v15 of keycloak.

@r3st
Copy link
Contributor Author

r3st commented Feb 28, 2023

Since 8 Years no change was made to this field, so I think the model was all time wrong.

/~https://github.com/keycloak/keycloak/blame/main/core/src/main/java/org/keycloak/representations/idm/ClientRepresentation.java#L65

@Nerzal
Copy link
Owner

Nerzal commented Feb 28, 2023

Thank you for checking!
And thank you for the contribution, i'll merge this now :)

@Nerzal Nerzal merged commit b703322 into Nerzal:main Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants