Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to navigate forward and backward using XButton1 and XButton2 … #26

Merged
merged 2 commits into from
May 5, 2024

Conversation

mostafa901
Copy link
Contributor

I see it would be a great feature if we can make the navigation between workspaces, using mouse buttons can be more convenient than moving and hovering the mouse to switch tabs.

For easy reference see how that looks

navigatebymouse

@NeVeSpl
Copy link
Owner

NeVeSpl commented May 4, 2024

I like the idea, from the beginning, the goal of RDBE was to provide "an internet browser" like experience, and this is a step in that direction.

But, you have chosen very peculiar places to place the code.

The added code from here TextBoxWithPlaceholder.xaml.cs should be located in MainWindow.xaml.cs, and what you have added to MainWindow.xaml.cs should be placed in WorkspacesViewModel.cs.

@mostafa901
Copy link
Contributor Author

Thanks for the feedback! I have made the necessary adjustments, and committed the changes. What you explained is correct and makes more scene.

@NeVeSpl NeVeSpl merged commit d24e482 into NeVeSpl:main May 5, 2024
1 check passed
@mostafa901 mostafa901 deleted the navigate-by-mouse branch May 5, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants