Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors which caused some unit tests failed to compile. #504

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

AtomicVar
Copy link
Contributor

MatX sets -Werror in its main CMakeLists.txt:

set(WARN_FLAGS ${WARN_FLAGS} $<$<COMPILE_LANGUAGE:CUDA>:-Werror all-warnings>)
set(WARN_FLAGS ${WARN_FLAGS} $<$<COMPILE_LANGUAGE:CXX>:-Werror>)

Thus all warnings are treated as errors, which may lead to compilation failures.

In this PR, I fixed some errors (warnings, e.g. comparing signed/unsigned numbers) and now all unit tests compiles fine.

@cliffburdick
Copy link
Collaborator

/blossom-ci

@cliffburdick
Copy link
Collaborator

Thanks @AtomicVar!

@cliffburdick cliffburdick merged commit 3cb7c0a into NVIDIA:main Oct 16, 2023
@AtomicVar AtomicVar deleted the fix-test-errors branch January 16, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants