Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Protections for Shift Operator inputs and fixed issues with size/Shape returns for certain input sizes #454

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

tylera-nvidia
Copy link
Collaborator

Found Issues when broadcasting/having mixed size inputs to the shift operator. These changes:

  • Adds additional runtime checks to the constructor of the operator to make sure both the input and shift operators are compatible with the desired output.
  • Fixed Rank function for situations where an input/shift operator may be broadcast during execution
  • Fixed Size function for situations where an input/shift operator may be expanded during execution

@tylera-nvidia
Copy link
Collaborator Author

All tests passed:

[==========] 1690 tests from 410 test suites ran. (1068782 ms total)
[  PASSED  ] 1690 tests.

  YOU HAVE 8 DISABLED TESTS

docker@33faaa8feed7:/home/tallen/scratch/playground/matxExample/MatX/build$ git status
On branch shiftRobustness
Your branch is up to date with 'origin/shiftRobustness'.

nothing to commit, working tree clean
docker@33faaa8feed7:/home/tallen/scratch/playground/matxExample/MatX/build$ git rev-parse HEAD
061c8f1eeda3fbc51f54cbf99accfbcba53542b1
docker@33faaa8feed7:/home/tallen/scratch/playground/matxExample/MatX/build$ 

@cliffburdick
Copy link
Collaborator

/blossom-ci

@cliffburdick cliffburdick merged commit 7d2a18c into main Jul 20, 2023
@cliffburdick cliffburdick deleted the shiftRobustness branch July 20, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants