Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unit tests for collapse with remap #255

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Adding unit tests for collapse with remap #255

merged 1 commit into from
Aug 25, 2022

Conversation

luitjens
Copy link
Collaborator

No description provided.

@@ -2618,6 +2618,90 @@ TEST(OperatorTests, Cast)
MATX_EXIT_HANDLER();
}

TEST(OperatorTestsAdvanced, AdvancedOp)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a TYPED_TEST where it tests over many times?

@luitjens luitjens force-pushed the collapse-tests branch 2 times, most recently from d3fa10c to 1926b7f Compare August 25, 2022 16:32
Fix lvalue semantics for collapse
@luitjens luitjens merged commit 3b71580 into main Aug 25, 2022
cliffburdick pushed a commit that referenced this pull request Dec 8, 2023
Fix lvalue semantics for collapse

Co-authored-by: jluitjens <jluitjens@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants