-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usability improvements for repo setup #106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me. I just have a question on what will happen if the user has not both torch and tf installed, if you are removing the pytest.importorskip()
Co-authored-by: Gabriel Moreira <gmoreira@nvidia.com>
Nothing changes, in the new setup we do this here: /~https://github.com/NVIDIA-Merlin/models/blob/usability/tests/tf/__init__.py#L18. So when tf/torch is not available it would never get to the individual test files. |
This PR does a few things:
pytest.importorskip
imports of tf/pytorch in our tests by moving this to the module-level. Therefore in the tests itself we can just import the frameworks in the default way.Makefile
with some common commands.