Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability improvements for repo setup #106

Merged
merged 8 commits into from
Dec 17, 2021
Merged

Usability improvements for repo setup #106

merged 8 commits into from
Dec 17, 2021

Conversation

marcromeyn
Copy link
Contributor

@marcromeyn marcromeyn commented Dec 16, 2021

This PR does a few things:

  • Gets rid of all the pytest.importorskip imports of tf/pytorch in our tests by moving this to the module-level. Therefore in the tests itself we can just import the frameworks in the default way.
  • Splits the CI/CD into tensorflow-tests, torch-tests & pre-commit. This makes the results easier to parse and by re-using pre-commit we can make the results closer to what you would get locally.
  • Introduces a Makefile with some common commands.

@marcromeyn marcromeyn marked this pull request as ready for review December 16, 2021 15:25
@marcromeyn marcromeyn self-assigned this Dec 16, 2021
Copy link
Member

@gabrielspmoreira gabrielspmoreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. I just have a question on what will happen if the user has not both torch and tf installed, if you are removing the pytest.importorskip()

Co-authored-by: Gabriel Moreira <gmoreira@nvidia.com>
@marcromeyn
Copy link
Contributor Author

Nothing changes, in the new setup we do this here: /~https://github.com/NVIDIA-Merlin/models/blob/usability/tests/tf/__init__.py#L18. So when tf/torch is not available it would never get to the individual test files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants