Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update set ach speed #61

Merged
merged 9 commits into from
Nov 2, 2023
Merged

Update set ach speed #61

merged 9 commits into from
Nov 2, 2023

Conversation

calbaker
Copy link
Collaborator

@calbaker calbaker commented Oct 25, 2023

Implemented the following in

pub fn set_ach_speed(&mut self, i: usize) -> Result<(), anyhow::Error> {

  • more descriptive variable names
  • use of closures to reduce redundancy

I did this to make it easier to see how to write this section in fastsim-3.

@calbaker calbaker requested a review from kylecarow October 25, 2023 18:12
Copy link
Collaborator

@kylecarow kylecarow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the logger stuff is all I care to change, I like the rest of the changes!!

python/fastsim/demos/__init__.py Outdated Show resolved Hide resolved
rust/Cargo.toml Show resolved Hide resolved
Co-authored-by: Kyle Carow <40699307+kylecarow@users.noreply.github.com>
@kylecarow kylecarow merged commit 7655b39 into fastsim-2 Nov 2, 2023
3 checks passed
@kylecarow kylecarow deleted the update-set-ach-speed branch November 2, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants