Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F2 doc fields #38

Merged
merged 21 commits into from
Aug 15, 2023
Merged

F2 doc fields #38

merged 21 commits into from
Aug 15, 2023

Conversation

calbaker
Copy link
Collaborator

@calbaker calbaker commented Aug 2, 2023

Added proc macro to create *_doc: Option<String> for most vehicle fields that can be skipped with #[doc_field(skip_doc)] attribute.

TODO:

  • make sure *_doc fields are accessible from python
  • publish fastim-proc-macros with new version
  • fix Cargo.toml path to not be local
  • improve documentation in fastsim-proc-macros/lib.rs

@calbaker calbaker marked this pull request as draft August 2, 2023 22:17
@calbaker
Copy link
Collaborator Author

calbaker commented Aug 2, 2023

@kylecarow , this isn't ready to merge, but it's a decent idea for you to play with it.

@calbaker calbaker marked this pull request as ready for review August 3, 2023 19:09
@kylecarow
Copy link
Collaborator

After discussion today, it seems we are in agreement that a separate doc struct is the way to go for this

@calbaker calbaker marked this pull request as draft August 10, 2023 22:34
@calbaker calbaker marked this pull request as ready for review August 14, 2023 23:06
@calbaker calbaker merged commit a210724 into fastsim-2 Aug 15, 2023
@calbaker calbaker deleted the f2-doc-fields branch August 15, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants