-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FASTSim 2.1.0 #29
FASTSim 2.1.0 #29
Conversation
… with vX.X.X, no more rX.X.X
@calbaker BTW, it looks like tagging the merge commit could probably done with an action as well. We could probably have the trigger be when a PR with |
…efault branch, but github cli can run it directly)
@calbaker I've readded Set up GitHub CLI with: Then run the workflow, e.g. on branch Does this sound ok to you? The wheels are still built and tested in |
.github/workflows/release.yaml
Outdated
# 'r[0-9]+.[0-9]+.[0-9]+' to match semantic version tag, e.g. r2.0.8 | ||
- "r[0-9]+.[0-9]+.[0-9]+" | ||
# 'v[0-9]+.[0-9]+.[0-9]+' to match semantic version tag, e.g. v2.0.8 | ||
- "v[0-9]+.[0-9]+.[0-9]+" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kylecarow , I'm thinking I like the solution Nick came up with in ALTRIOS:
/~https://github.com/NREL/altrios-private/blob/cf47f12f24589ad01a3f71dba4c0af272be6c12e/.github/workflows/wheels.yaml#L5
@calbaker This should be ready for review
I've modified the workflows so that the wheel files are built and tested, then when all runs in the matrix complete, a separate job uploads them to PyPI. I've kept the
vX.X.X
format as the trigger, rather thanrX.X.X
. I have not tested the twine portion of this, but it uses the same uploading instructions as the originalrelease.yaml
does, so I imagine it should work.Some next steps:
v2.1.0
and watchrelease.yaml
go to work!