Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FASTSim 2.1.0 #29

Merged
merged 5 commits into from
Jul 5, 2023
Merged

FASTSim 2.1.0 #29

merged 5 commits into from
Jul 5, 2023

Conversation

kylecarow
Copy link
Collaborator

@calbaker This should be ready for review

I've modified the workflows so that the wheel files are built and tested, then when all runs in the matrix complete, a separate job uploads them to PyPI. I've kept the vX.X.X format as the trigger, rather than rX.X.X. I have not tested the twine portion of this, but it uses the same uploading instructions as the original release.yaml does, so I imagine it should work.

Some next steps:

  • review the changes to the files, especially the workflows
  • if tests pass, approve & merge this PR
  • tag the merge commit with v2.1.0 and watch release.yaml go to work!

@kylecarow kylecarow requested a review from calbaker June 15, 2023 15:52
@kylecarow
Copy link
Collaborator Author

@calbaker BTW, it looks like tagging the merge commit could probably done with an action as well. We could probably have the trigger be when a PR with vX.X.X in the title and/or a release label is merged.

Kyle Carow added 2 commits June 27, 2023 13:55
@kylecarow
Copy link
Collaborator Author

kylecarow commented Jun 27, 2023

@calbaker I've readded wheels.yaml, and changed its trigger to workflow_dispatch. Like we discussed last week, this only allows it to be run from github.com on the default branch. However, if you download the GitHub CLI, you can run it manually on non-default branches as well.

Set up GitHub CLI with:
brew install gh
gh auth login

Then run the workflow, e.g. on branch fastsim-2.1.0:
gh workflow run wheels -r fastsim-2.1.0

Does this sound ok to you? The wheels are still built and tested in release.yaml before anything is published to PyPI.

# 'r[0-9]+.[0-9]+.[0-9]+' to match semantic version tag, e.g. r2.0.8
- "r[0-9]+.[0-9]+.[0-9]+"
# 'v[0-9]+.[0-9]+.[0-9]+' to match semantic version tag, e.g. v2.0.8
- "v[0-9]+.[0-9]+.[0-9]+"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kylecarow kylecarow merged commit 4ffaeff into fastsim-2 Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants