Network enhancements #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ults that we expect
…ivate into trial/add-simple-network
…trios-private into trial/add-simple-network
formatting stuff removed boiler plate stuff that could be simplified with defaults
…trios-private into trial/add-simple-network
…ivate into trial/add-simple-network
…trios-private into trial/add-simple-network
…ivate into trial/add-simple-network
… but uses inefficient `clone` calls
…alt: 0` instead of duplicating `idx_next`
…ivate into network-enhancements
… instead. This would allow for having one struct with `Vec<SpeedSet>` and `train_type` as field ind `SpeedSet` and another struct with `HashMap<TrainType, SpeedSet>` to make the causal relationship more obvious.
…elated tests are passing
TODO: update speed trace to be 1 Hz
- figure out if hashing is significant CPU cost - Make a train-type-agnostic `SpeedSet`
updated pyi file
sim_manager_demo.py takes about 33-55 s, depending on CPU load
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link.speed_setthat is a train-type-neutral speed limit vector that, if provided, overrides the map of train types and corresponding speed limitsSpeedSets