Speed-up battery parsing #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephmckinsey
requested review from
claytonpbarrows,
daniel-thom and
sourabhdalvi
Codecov Report
@@ Coverage Diff @@
## master #903 +/- ##
=======================================
Coverage 89.13% 89.13%
=======================================
Files 155 155
Lines 7466 7466
=======================================
Hits 6655 6655
Misses 811 811
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PowerSystems table parsing has O(n^2) complexity for parsing batteries, where every row of the storage data frame is iterated or each battery. This pull request creates a map to the storage head and tail instead as a preprocessing step.