-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to specify equality predicate for compare_values and provide a more sensible default (PSY) #1159
Conversation
Tests are failing in CI due to the dependency on the IS companion branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the better implementation for sophisticated users is to implement
IS.compare_values(
match_fn::Function,
x::T,
y::T;
compare_uuids = false,
exclude = Set{Symbol}(),
and forward
IS.compare_values(
x::T,
y::T;
compare_uuids = false,
exclude = Set{Symbol}(),
to
IS.compare_values(
IS.isequivalent,
x::T,
y::T;
compare_uuids = false,
exclude = Set{Symbol}(),
and provide a more sensible default.
d3184b3
to
e2a8039
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1159 +/- ##
=======================================
Coverage 84.52% 84.52%
=======================================
Files 179 179
Lines 8167 8169 +2
=======================================
+ Hits 6903 6905 +2
Misses 1264 1264
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@jd-lara checks are passing now that the IS companion is merged |
Companion to NREL-Sienna/InfrastructureSystems.jl#387, see discussion (including of backwards compatibility) there.