Add is_component_in_aggregation_topology
#1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1146 +/- ##
=======================================
Coverage 84.60% 84.61%
=======================================
Files 177 177
Lines 8108 8111 +3
=======================================
+ Hits 6860 6863 +3
Misses 1248 1248
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jd-lara
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
@rodrigomha this would be useful later for the NTP EI repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For PowerAnalytics/
ComponentSelector-related reasons, it is useful to be able to test whether a givenComponentis within a givenAggregationTopologywithout having a reference to the relevantSystem. This exposes that functionality. I also made the existingget_component_in_aggregation_topologytest more thorough.