Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kdrh/psy4 docs renaming #1141

Merged
merged 17 commits into from
Jul 2, 2024
Merged

Kdrh/psy4 docs renaming #1141

merged 17 commits into from
Jul 2, 2024

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Jul 1, 2024

No description provided.

claytonpbarrows and others added 9 commits June 12, 2024 19:55
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@jd-lara jd-lara requested a review from GabrielKS July 1, 2024 20:01
@jd-lara jd-lara self-assigned this Jul 1, 2024
@jd-lara jd-lara added the PARSING issues related to parsing come label Jul 1, 2024
@GabrielKS
Copy link
Collaborator

Context: this PR relating to the parser code was merged, but it was merged into another feature branch that did not subsequently make it into main for some reason.

@rodrigomha rodrigomha self-requested a review July 2, 2024 01:05
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 88.57143% with 8 lines in your changes missing coverage. Please review.

Project coverage is 84.60%. Comparing base (e6f1161) to head (c40ec43).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1141      +/-   ##
==========================================
- Coverage   84.60%   84.60%   -0.01%     
==========================================
  Files         177      177              
  Lines        8083     8108      +25     
==========================================
+ Hits         6839     6860      +21     
- Misses       1244     1248       +4     
Flag Coverage Δ
unittests 84.60% <88.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/parsers/power_models_data.jl 91.94% <100.00%> (ø)
src/parsers/power_system_table_data.jl 81.90% <88.40%> (-0.39%) ⬇️

... and 3 files with indirect coverage changes

@jd-lara
Copy link
Member Author

jd-lara commented Jul 2, 2024

The PSB tests are expect to fail due to the new implementation of the CDM parser.

@jd-lara jd-lara merged commit 13b8464 into main Jul 2, 2024
10 of 11 checks passed
@jd-lara jd-lara deleted the kdrh/psy4_docs_renaming branch July 2, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PARSING issues related to parsing come
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants