Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make select() smarter #63

Closed
EricEngle-NOAA opened this issue Mar 28, 2023 · 0 comments
Closed

make select() smarter #63

EricEngle-NOAA opened this issue Mar 28, 2023 · 0 comments
Assignees
@EricEngle-NOAA
Labels
enhancement New feature or request
Milestone
v2.0

Comments

@EricEngle-NOAA
Copy link
Collaborator

Currently, the select() method for the grib2io.open object does not avoid grib2 messages where an attribute is not available. When this happens, grib2io raises an AttributeError.
@EricEngle-NOAA EricEngle-NOAA added the enhancement New feature or request label Mar 28, 2023
@EricEngle-NOAA EricEngle-NOAA added this to the v2.0 milestone Mar 28, 2023
@EricEngle-NOAA EricEngle-NOAA self-assigned this Mar 28, 2023
EricEngle-NOAA added a commit that referenced this issue Mar 29, 2023
@EricEngle-NOAA
Update for _grib2io.py
b838615 
updated logic in open.select() to now ignore GRIB2 messages where an
attribute does not exist.  Previously this would raise an AttributeError
that made using select() a bit cumbersome.

fixed issue in pack() method to now correctly handle packing a GRIB2
message with a bit map.  The issue was some leftover code from how
ncepgrib/grib2io v1.x handled this.

This commit references issues #62 and #63.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EricEngle-NOAA EricEngle-NOAA

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
1 participant
@EricEngle-NOAA