Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds Matomo anonymous cookie-free tracking + privacy policy page #419

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

egpbos
Copy link
Member

@egpbos egpbos commented Dec 18, 2024

Cannot get the Matomo opt-out to work, though, the message doesn't show (at least on my laptop). I left in the commented out code necessary to get the opt-out on the Privacy page.

Changes in this PR

Fixes #341.

Checklist

ALL contributions

  • I previewed my changes locally using e.g. python3 -m http.server 4000 and confirmed they work correctly.
  • I checked for broken links, e.g. using the link checker GitHub Action workflow, or locally by using docker run --init -it -v `pwd`:/docs lycheeverse/lychee /docs --config=docs/lychee.toml, at least for the files I changed.
  • My name was added to the CITATION.cff file.

@egpbos egpbos requested a review from ewan-escience December 18, 2024 21:02
Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for nlesc-guide-testing ready!

Name Link
🔨 Latest commit f5d7384
🔍 Latest deploy log https://app.netlify.com/sites/nlesc-guide-testing/deploys/676434dba9538c000836c01f
😎 Deploy Preview https://deploy-preview-419--nlesc-guide-testing.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Cannot get the Matomo opt-out to work, though, the message doesn't show (at least on my laptop). I left in the commented out code necessary to get the opt-out on the Privacy page.
Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The privacy page looks fine to me. I have no idea if the tracking works though.

@egpbos
Copy link
Member Author

egpbos commented Dec 19, 2024

Me neither, let's try!

@egpbos egpbos merged commit 8e33f51 into main Dec 19, 2024
8 checks passed
@egpbos egpbos deleted the 341_matomo branch December 19, 2024 15:21
@egpbos egpbos mentioned this pull request Dec 19, 2024
@c-martinez
Copy link
Member

I guess only communications team has access to Matomo to check it is working properly? We should probably ask @VeronicaWYPang if she can help us with checking?

@egpbos
Copy link
Member Author

egpbos commented Dec 21, 2024

No, I have access and it is working... a bit. See #421.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Matomo tracking
3 participants