Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Loading error since the ISchool change the redirect mechanism #206

Merged
merged 12 commits into from
Oct 21, 2023
Merged

Fix: Loading error since the ISchool change the redirect mechanism #206

merged 12 commits into from
Oct 21, 2023

Conversation

ntut-xuan
Copy link
Collaborator

@ntut-xuan ntut-xuan commented Oct 21, 2023 •
edited
Loading

Description

See: #202

I-School changed the redirect mechanism and caused the error.

Also see the redirect step: 953570beb7342f34af7385c534f194eeae6e35b5

How to Verify?

  • Check the announcement in the course can show smoothly.
  • Check the attachment in the course can show smoothly.

@ntut-xuan ntut-xuan added type: bug Something isn't working priority: high labels Oct 21, 2023
@ntut-xuan ntut-xuan self-assigned this Oct 21, 2023
Xanonymous-GitHub
Xanonymous-GitHub reviewed Oct 21, 2023
View reviewed changes
lib/src/connector/ischool_plus_connector.dart Outdated Show resolved Hide resolved
lib/src/connector/ischool_plus_connector.dart Outdated Show resolved Hide resolved
lib/src/connector/ischool_plus_connector.dart Outdated Show resolved Hide resolved
lib/src/connector/ischool_plus_connector.dart Outdated Show resolved Hide resolved
lib/src/connector/ischool_plus_connector.dart Outdated Show resolved Hide resolved
lib/src/connector/ischool_plus_connector.dart Outdated Show resolved Hide resolved
lib/src/connector/ischool_plus_connector.dart Outdated Show resolved Hide resolved
@ntut-xuan ntut-xuan added this to the 1.4.5 milestone Oct 21, 2023
Xanonymous-GitHub
Xanonymous-GitHub approved these changes Oct 21, 2023
View reviewed changes
Copy link
Member

@Xanonymous-GitHub Xanonymous-GitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ntut-xuan ntut-xuan merged commit ca55e5c into master Oct 21, 2023
4 checks passed
@ntut-xuan ntut-xuan deleted the 202-ischool-loading-error branch October 21, 2023 17:39
@ntut-xuan ntut-xuan mentioned this pull request Oct 23, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xanonymous-GitHub Xanonymous-GitHub Xanonymous-GitHub approved these changes

@rileychh rileychh Awaiting requested review from rileychh

@ricky9667 ricky9667 Awaiting requested review from ricky9667

@James-Lu-none James-Lu-none Awaiting requested review from James-Lu-none

Assignees

@ntut-xuan ntut-xuan

Labels
priority: high status: ready to merge type: bug Something isn't working
Projects
None yet
Milestone
1.4.5
Development

Successfully merging this pull request may close these issues.
2 participants
@ntut-xuan @Xanonymous-GitHub