Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/1.4.4 #197

Merged
merged 10 commits into from
Aug 3, 2023
Merged

Release/1.4.4 #197

merged 10 commits into from
Aug 3, 2023

Conversation

Xanonymous-GitHub
Copy link
Member

Description

Release 1.4.4.
Genernally upgrade outdated dependencies for better compatibility in new platforms.

Upgrade Android compile SDK version to 34 (Android 14).

How to Verify?

This release is mainly focus on #195. For verify this feature, please refer to the issue and perform the regression.

Screenshots/GIF/Test Results (Optional)

@Xanonymous-GitHub Xanonymous-GitHub marked this pull request as draft August 2, 2023 15:32
@Xanonymous-GitHub
Copy link
Member Author

Since #195, we have selected some school-related APIs to migrate to the new encoding. However, it has been confirmed that some of these APIs still use different encodings between us.

@Xanonymous-GitHub
Copy link
Member Author

Based on #197 (comment), an alpha-test has been required.

In this alpha-testing, we may need to carefully test the issue mentioned in #195, with both Chinese and English mode.

@Xanonymous-GitHub Xanonymous-GitHub marked this pull request as ready for review August 2, 2023 16:51
@Xanonymous-GitHub
Copy link
Member Author

Xanonymous-GitHub commented Aug 2, 2023

The existing issue from #195 is mainly as this:

  • The score page can not normally refresh/fetch score content since TAT sometimes send a wrong encoding courseId to school course system. Then, the system will respond like this:
截圖 2023-08-02 下午11 25 15

Then, we found the wrong-encoding courseId here:

截圖 2023-08-02 下午11 34 50

For dealing with this, we studied that the problem is inside the _addScoreRankTask function, which is called by clicking the refresh button on the score page's bar.

Inside the _addScoreRankTask function, we did two tasks:

  • ScoreRankTask
  • CourseExtraInfoTask

The first task aims for get some rank related data from server, and then save them into local storage after finished.
However, this task do more thing as we expected. It also save courseInfoList into local storage, which will be used by the next task. And in #195, we missed this task's wrong encoding.

That's why we got wrong courseIds while doing the CourseExtraInfoTask.

Hence, the possible solution would be remove the big5 encoding config from the ScoreRankTask.

Addressed in a4b5ac6.

@Xanonymous-GitHub Xanonymous-GitHub merged commit 4e0fbb8 into master Aug 3, 2023
@Xanonymous-GitHub Xanonymous-GitHub deleted the release/1.4.4 branch August 3, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant