Add VSCode formatter configuration #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xanonymous-GitHub
previously approved these changes
Mar 30, 2023
There was a problem hiding this comment.
LGTM with little comments.
Suggest improving branch name in the future for better readability. The name vscode-settings may contains the following problems:
- lack of verbs, don't know what to do
- Lack of a single identifying statement or word, difficult to distinguish from one another when there are similar names.
So based on above points, you may named it to something like add-vscode-dart-format-config.
But this is just a nit problem. Feel free to merge and be careful in the future while naming.
rileychh
force-pushed
the
vscode-settings
branch
from
5fe7bdb to
8b3acbd
Compare
|
Forgot to sign the commits. Can you approve again? Thanks. |
Xanonymous-GitHub
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.github/workflows/analysis.yml.How to Verify?
Format Documentcommand in any Dart file.Screenshots/GIF/Test Results (Optional)
None.