-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine simple login result handler for the separated password expiration states #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xanonymous-GitHub
force-pushed
the
fix-reset-password-not-show
branch
from
February 16, 2023 17:26
916c9f6
to
572c507
Compare
The |
Xanonymous-GitHub
changed the title
Fix reset password not show
Refine simple login result handler for the separated password expiration states
Feb 17, 2023
Xanonymous-GitHub
added a commit
that referenced
this pull request
Mar 28, 2023
…ion states (#166) * chore: upgrade packages * refactor: migrate from old core version * feat: update new login flow * refactor: migrate msg dialog to null-safety * chore: generate i18n files * chore: update with tat_core * chore: refine i18n generation script * chore: add intl_utils for script * refactor: provide navigator key * refactor: refine handle login steps with new passwordExpired state * refactor: add new dialog return method * chore: update ios lock file * feat: disable showing dialog while verifyMobile case occurred * chore: enable iPad full orientation for using multitask
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #164 we've tried to use a new flow on login task, however, the school's server seems not allow us to do it.
So after tat_core updated to the latest logic, we tried to apply them into login task in this PR.
How to Verify?
Normally login to an account, see what happened. (You may need to logout first)
There are some cases that you may meet:
Screenshots/GIF/Test Results (Optional)