Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine simple login result handler for the separated password expiration states #166

Merged
merged 14 commits into from
Feb 18, 2023

Conversation

Xanonymous-GitHub
Copy link
Member

@Xanonymous-GitHub Xanonymous-GitHub commented Feb 4, 2023

Description

In #164 we've tried to use a new flow on login task, however, the school's server seems not allow us to do it.
So after tat_core updated to the latest logic, we tried to apply them into login task in this PR.

How to Verify?

Normally login to an account, see what happened. (You may need to logout first)

There are some cases that you may meet:

  1. just login..
  2. You're username or password not correct -> the login page should remain in front of you.
  3. You're account was locked by some reasons -> the login page should remain in front of you.
  4. You may need to update your password, otherwise it will expire in xx days -> still can go in to home page but a warning dialog shown.
  5. You may need to update your phone number, otherwise it will expire in xx days -> still can go in to home page but a warning dialog shown.
  6. Unknown error happened.

Screenshots/GIF/Test Results (Optional)

@Xanonymous-GitHub Xanonymous-GitHub added the type: bug Something isn't working label Feb 4, 2023
@Xanonymous-GitHub Xanonymous-GitHub added this to the 1.4.3 milestone Feb 4, 2023
@Xanonymous-GitHub Xanonymous-GitHub self-assigned this Feb 4, 2023
@Xanonymous-GitHub Xanonymous-GitHub force-pushed the fix-reset-password-not-show branch from 916c9f6 to 572c507 Compare February 16, 2023 17:26
@Xanonymous-GitHub
Copy link
Member Author

The MsgDialog should shown across different route.

@Xanonymous-GitHub
Copy link
Member Author

For the #167, since we have disabled all the landscape orientations for both iOS and iPadOS, the multitask feature on iPad has been disabled, too.

So for urgent release, we have opened all the orientation config for iPadOS again in this PR.
Addressed in f4334af.

@Xanonymous-GitHub Xanonymous-GitHub changed the title Fix reset password not show Refine simple login result handler for the separated password expiration states Feb 17, 2023
@Xanonymous-GitHub Xanonymous-GitHub merged commit 8d541a1 into master Feb 18, 2023
@Xanonymous-GitHub Xanonymous-GitHub deleted the fix-reset-password-not-show branch February 18, 2023 11:03
Xanonymous-GitHub added a commit that referenced this pull request Mar 28, 2023
…ion states (#166)

* chore: upgrade packages

* refactor: migrate from old core version

* feat: update new login flow

* refactor: migrate msg dialog to null-safety

* chore: generate i18n files

* chore: update with tat_core

* chore: refine i18n generation script

* chore: add intl_utils for script

* refactor: provide navigator key

* refactor: refine handle login steps with new passwordExpired state

* refactor: add new dialog return method

* chore: update ios lock file

* feat: disable showing dialog while verifyMobile case occurred

* chore: enable iPad full orientation for using multitask
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha-test type: bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant