Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bottom bar and file downloads #158

Merged
merged 8 commits into from
Jan 26, 2023

Conversation

Xanonymous-GitHub
Copy link
Member

@Xanonymous-GitHub Xanonymous-GitHub commented Jan 5, 2023

Description

This PR did these things:

  • change the bottomNavigationStyle to fixed (which shows the label)
  • Add success & failed dialog to file download process.
  • fix illegal firebase access while initializing
  • remove unneeded aos permissions.

How to Verify?

  • TBD

Screenshots/GIF/Test Results (Optional)

@Xanonymous-GitHub
Copy link
Member Author

Xanonymous-GitHub commented Jan 5, 2023

The External storage permission of AOS could not be requested now.
Baseflow/flutter-permission-handler#888 (comment)
And this problem may caused by the permission_handler package not supporting API 33+.
Below is the case that I run on API 32, which works fine.
截圖 2023-01-06 上午6 26 42

@Xanonymous-GitHub Xanonymous-GitHub marked this pull request as ready for review January 26, 2023 08:47
@Xanonymous-GitHub Xanonymous-GitHub merged commit 164a48c into master Jan 26, 2023
@Xanonymous-GitHub Xanonymous-GitHub deleted the improve-bottom-bar-and-file-downloads branch January 26, 2023 08:48
Xanonymous-GitHub added a commit that referenced this pull request Mar 28, 2023
* feat: change bottom nav bar style to fixed

* refactor: migrate file store to null safety

* fix: illegal access firebase for auto roll call while feature not enabled

* refactor: migrate toast to null safety

* refactor: migrate permission util to null safety

* refactor: migrate file download to null safety, and add dialog while download complete

* refactor: migrade iplus file page to null safety

* chore: remove unneeded aos permissions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha-test status: help wanted Extra attention is needed
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Feature: Show a message while the file download process finished
1 participant