Refactor score page (Only score parts) #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate appbar buttons to two
Xanonymous-GitHub
changed the title
ricky9667
reviewed
Jan 4, 2023
…n any params for building
|
For all mistakes made by the former maintainer, through the file will be refactored again in the future (maybe?), they may not needed to be fixed at this moment, since all changes will be replaced with something new again. |
… buttons with tooltip
Xanonymous-GitHub
added a commit
that referenced
this pull request
Mar 28, 2023
* feat: rewrite score tile widget * feat: extract & rewrite the section of course score * feat: add i18n text for key of class and department * refactor: define highlight color for origin divider color * feat: add metrics title widget * feat: add grade metrics cell widget * feat: rewrite semester score section to new metrics style * feat: rewrite two rank sections to new metrics style * refactor: rename widget * fix: incorrect theme divider color use * feat: rewrite warning widget and extract from score page * refactor: use refactored widgets to tidy up the score page, and seperate appbar buttons to two * fix: i10n key typo * refactor: use getter to generate sub widgets while it is not depend on any params for building * refactor: seperate appbar action buttons into isolate widget and wrap buttons with tooltip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tried to refactor the score page (also known as the grade page), which specifically did the following things:
course scoresectionsemester scoresectionranksectionrefreshandcalculate credit, which were originally located in aPopupMenuButton, has been redesigned toIconButtondirectly put inside theAppBar.Dividerwidget in somewhere.How to Verify?
refreshbutton in the appbar, check if it works.calculatebutton in the appbar, check if it works.Screenshots/GIF/Test Results (Optional)