Added automated build action #3
Conversation
| push: | ||
| branches: ["main"] | ||
| pull_request: | ||
| branches: ["main"] |
There was a problem hiding this comment.
Since you are using upload-release-action step, I doubt it will work without a ref to a release. So I think it is better to change to something like on tag creation or on release creation.
Example:
on:
release:
types: [published]
|
As far as the main branch contains the files. It will work. Inshallah. I tested it with the forked code. It works there. |
I see, sure it will work. But I feel we should not be creating a new release every time the code is pushed to the branch. Also, the tag value is hardcoded. |
| uses: svenstaro/upload-release-action@v2 | ||
| with: | ||
| repo_token: ${{ secrets.GITHUB_TOKEN }} | ||
| file: build\windows\x64\runner\Release\quran_publisher_desktop.exe |
There was a problem hiding this comment.
Flutter Windows app cannot run with only the .exe, it needs .dll files as well.
Read detail here: https://docs.flutter.dev/platform-integration/windows/building#building-your-own-zip-file-for-windows
There was a problem hiding this comment.
will check into it
| tag: v1.0-${{ github.run_number }} | ||
| overwrite: true | ||
| body: "It's beta" |
There was a problem hiding this comment.
well we could change the tag. We can get the version from pubscpec.yaml. And for body, what you have in mind?
|
@shaaanuu Your PR has been merged to main but with minor modification. See it in actions. I want to clean up few things first before we do the first release. Thank you for your help. 😄 Ohh, and if you're interested, you can try to do CI for build .deb & .rpm package. I tried using https://pub.dev/packages/flutter_distributor but not fully working on my machine (maybe because I'm using WSL) |
|
Mine is arch. Even though I tried build it, I can't test it |
It uses the github's action for building and uploading the builds into the tags section.
currently it contains windows and linux.
macos shows some errors, so i will look into it ( and i don't think it will work without signing the build).