Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add directly used dependency #98

Merged
merged 2 commits into from
Jun 22, 2020
Merged

Conversation

palindrom615
Copy link
Contributor

bluebird, lines-and-columns, lodash, memoizesync, postcss, specificity is directly used in this repo but is not in the package.json. This causes error when using sub font with yarn.

> rg '\b(bluebird|lines-and-columns|lodash|memoizesync|postcss|specificity)\b'

lib/subsetLocalFont.js
17:const Promise = require('bluebird');

lib/getCssRulesByProperty.js
1:const specificity = require('specificity');
2:const postcss = require('postcss');
43:  const parseTree = postcss.parse(cssSource);
81:        // Split up combined selectors as they might have different specificity
82:        specificity
125:          // Split up combined selectors as they might have different specificity
126:          specificity
154:        // Split up combined selectors as they might have different specificity
155:        specificity
189:        // Split up combined selectors as they might have different specificity
190:        specificity
227:        specificity

lib/subsetFonts.js
1:const _ = require('lodash');
2:const Promise = require('bluebird');
3:const memoizeSync = require('memoizesync');
21:const LinesAndColumns = require('lines-and-columns').default;

adding those dependencies might fix the problems

@coveralls
Copy link

Pull Request Test Coverage Report for Build 341

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.422%

Totals Coverage Status
Change from base Build 334: 0.0%
Covered Lines: 993
Relevant Lines: 1063

💛 - Coveralls

@papandreou papandreou merged commit bf93ce6 into Munter:master Jun 22, 2020
@papandreou
Copy link
Collaborator

Thanks! Released in 5.0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants